Add typings and development setup#48
Open
LindezaGrey wants to merge 1 commit intodavidaurelio:masterfrom
Open
Conversation
Create Dockerfile Create docker-compose.yml Update docker-compose.yml add more config remove python2 support add typing add development setup merge commits
Owner
|
hey @LindezaGrey, sorry for not reacting earlier. I will get to this over the weekend. Thanks for contributing! |
|
Hi @davidaurelio, just wonder when will |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
this pull request changes the following things:
In order to make it easier to contribute i added a devcontainer setup, which can be used with Github Codespaces in order to directly run and test the code in the browser.
I updated the code with all necessary typing, to address this issue #47
Additionally it was checked by ruff & mypy and formatted with black. All tests still pass.